fix: reorder autosave tick to account for weak hardware#1482
Merged
sylvessa merged 1 commit intoMCLCE:mainfrom Apr 6, 2026
Merged
fix: reorder autosave tick to account for weak hardware#1482sylvessa merged 1 commit intoMCLCE:mainfrom
sylvessa merged 1 commit intoMCLCE:mainfrom
Conversation
itsRevela
pushed a commit
to itsRevela/LCE-Revelations
that referenced
this pull request
Apr 11, 2026
itsRevela
added a commit
to itsRevela/LCE-Revelations
that referenced
this pull request
Apr 11, 2026
Reviewed 8 upstream commits from smartcmd/MCLCE/MinecraftConsoles and recorded the result as a merge so GitHub stops reporting "behind upstream". All accepted changes were cherry-picked earlier in this branch, and this commit only absorbs the upstream commit SHAs as reachable ancestors using the "ours" merge strategy, so no tree changes come in from this commit itself. Applied: - 98a86fc feat: set intro scene background to white (MCLCE#1474) - 413baac fix: reorder autosave tick to account for weak hardware (MCLCE#1482) - d25b762 Fix _jeb easter egg on sheep (MCLCE#1488) Partially applied: - d0786f9 Update more references to old smartcmd repo (credits reorganization and Star History URL applied, Nightly download URLs dropped since our fork has its own release pipeline, itsRevela added to Project Maintainers on top of upstream's restructure) Already present: - b928351 Update Windows64_Minecraft.cpp (MCLCE#1468). Unicode WinAPI conversion was already applied during our Linux cross-compile work, so this was a no-op cherry-pick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
reorders and does some autosave fixes to account for weaker hardware with big worlds
Changes
Previous Behavior
when a user decides to close the server in the middle of an autosave, it would try to save twice, crash
if an autosave happens too fast in consistency (low autosave timer), crash if they conflict
Root Cause
design flaw on my part, no proper checks for if it was autosaving or not in certain loops and the autosave loop too
New Behavior
autosave loop now checks if a pending autosve is happening properly now
when you close the server, it checks if an autosave is happening, and lets it do its thing before closing fully
Fix Implementation
added a bunch of checks regarding if an autosave is happening, and if everything hasnt been flushed yet
AI Use Disclosure
no